search

kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
497 stars 145 forks source link

Fix for displaying dropped dice indication for advantage/disadvantage in roll20, when using digital dice and D&D 5E By Roll20 template #948

Closed Cube-o closed 2 years ago

Cube-o commented 2 years ago

Problem: When rolling with advantage/disadvantage into roll20, while using digital dice and the D&D 5E By Roll20 template, both rolls were shown in dark black. Correctly one of them should be lighter to indicate it being dropped due to the advantage/disadvantage. Currently showing: image Correct version for disadvantage: image

Changes summary: Originally attack prop always: "1" was being added. I added 2 special cases for when the roll is indicated to be with advantage/disadvantage and the number of rolled dice is 2 (because rolls beyond 2 are grouped into the second roll and the advantage indicator in the template is unable to process those)

kakaroto commented 2 years ago

Huh... so that works using the actual result even if no dice are actually rolled? I thought that didn't work for some reason 🤔

Cube-o commented 2 years ago

Huh... so that works using the actual result even if no dice are actually rolled? I thought that didn't work for some reason 🤔

Was honestly a bit surprised myself, so I was thinking "oh, if this would work..." and then it did.

kakaroto commented 2 years ago

Awesome, thanks, will merge it! 👍