kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
497 stars 145 forks source link

Spells with max AND min results on any dice show incorrectly with Roll20 Dark mode #954

Closed Galphanore closed 2 years ago

Galphanore commented 2 years ago

Describe the bug If you have the new Roll 20 "Dark Mode" enabled and cast a spell, sometimes the resulting value has a text color that matches the background color.

To Reproduce Steps to reproduce the behavior:

  1. Have Roll20, DNDBeyond, and Beyond20
  2. Turn on Roll20 Dark Mode
  3. Cast a spell and get a max value on any dice (8 on a d8, 6 on a d6, etc) AND a 1 on any dice, for the same roll.
  4. The text color and background color of the result are the same, so you cannot see the result.

Note : Easier to replicate on spells like Healing Word that use a d4, for obvious reasons.

Expected behavior The text should change color when dark mode is swapped on and off.

Screenshots Attached.

Browser Info (please complete the following information): Happening both on Chrome 98.0.4758.102 and Firefox 97.0.1.

Additional context Looking at the HTML, it looks rolls with the span class of "importantroll" have a hardcoded color that matches the background color.

Beyond20DarkMode Beyond20DarkModeHtml Thunderwave ThunderwaveHTML HealingWord HealingWordHTML

Aeristoka commented 2 years ago

That's an issue with roll20 dark mode not anything with Beyond20. Roll20 doesn't have a fully functional dark mode yet.

Aeristoka commented 2 years ago

Try rolls from a roll 20 character sheet you'll get the same result.

Galphanore commented 2 years ago

Ok, thanks! I wasn't sure where the issue was coming from. I'll submit a bug report to them.

Aeristoka commented 2 years ago

I wish they could get even like one code change right... Dark mode is hard for everybody but they really screwed it up.

Galphanore commented 2 years ago

Yeah :(