search

kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
497 stars 145 forks source link

Adventure flowchart in the call of the Netherdeep does not display properly with Beyond20 #957

Closed Xtallll closed 2 years ago

Xtallll commented 2 years ago

Describe the bug Adventure flowchart in the Call of the Netherdeep dose not render properly with Beyond20 enabled.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'ADVENTURE FLOWCHART'
  2. the Flowchart is only displaying the gradient background not the text

Screenshots With Beyond20 disabled withoutbeyond20

With Beyond20 enabled withbeyond20

Browser Info (please complete the following information):

Jonfor commented 2 years ago

This happens to me as well in Firefox 98.0.1.

Jonfor commented 2 years ago

It's strange because if I Inspect Element and uncheck the z-index: -1 and recheck it on the ::before on the aside class="cotn-flowchart" it displays properly again.

kakaroto commented 2 years ago

Very weird indeed! As we don't do anything that might affect that flowchart. Even looking at the elements, I see a difference between the CSS. This is with B20 enabled : image And this is without : image

Notice that where the issue happens, the z-index: -1 doesn't even exist in the CSS....

And.... 🤦‍♂️ here's the CSS in the <style> header of the html : Correct : image

Incorrect : image

And so... wow it looks like Beyond20 is replacing the -1 in the CSS as if it's a dice roll modifier for 1d20-1, thus breaking the CSS! 🤦‍♂️ 😱

Thanks for reporting this bug! Will get it fixed!

Aeristoka commented 2 years ago

They put the CSS... In the Header... Of the page...?

kakaroto commented 2 years ago

They put the CSS... In the Header... Of the page...?

as a <style> element, yes. It's very normal to do that, as it's a page-specific style.

Aeristoka commented 2 years ago

They put the CSS... In the Header... Of the page...?

as a <style> element, yes. It's very normal to do that, as it's a page-specific style.

Seems like it might have been better if they included a CSS file just for the page... just to keep it modular...

kakaroto commented 2 years ago

Fixed! And the good news is that it wasn't always modifying style, only this one for that specific page, because the <div class="primary-content"> (which is what we parse for dice formulas) had the style in it! 🤦‍♂️ I thought it was in the <head> of the page, but nope... so I expect that this bug only affected that page, not everything else. Either way, it's fixed now! 👍