kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
497 stars 145 forks source link

Advantage plus custom roll adds custom roll twice #962

Closed cmbarona closed 2 years ago

cmbarona commented 2 years ago

Describe the bug I set up a custom roll to account for Superiority Dice: +1d8. When I apply this to a roll with advantage, it rolls the extra d8 twice.

To Reproduce Steps to reproduce the behavior:

  1. Open the Beyond20 Hotkey Manager
  2. Add New Hotkey: Override Global Settings: Custom Modifier: Custom Formula = 1d8
  3. Activate the new hotkey in tandem with any Advantage or Disadvantage hotkey
  4. Activate any applicable roll

Expected behavior The roll would be made with advantage, but the custom dice would only be rolled once and its result applied equally to both Advantage rolls. In other words, Expected: {(Advantage Roll 1 + Ability + Proficiency) + (Custom Roll 1)} ; {(Advantage Roll 2 + Ability+ Proficiency) + (Custom Roll 1)} Actual: {Advantage Roll 1 + Ability+ Proficiency + Custom Roll 1} ; {Advantage Roll 2 + Ability+ Proficiency + Custom Roll 2}

Screenshots image image

Browser Info (please complete the following information):

Aeristoka commented 2 years ago

This is directly related to how rolls are processed by Beyond20, and very explicitly when rolls are sent to be processed by FoundryVTT/Astral/Roll20, we have no way to process something like this on that end, as the roll results are just posted, so this is going to be the behavior, unless @kakaroto has some other input on it.

Aeristoka commented 2 years ago

Confirmed Duplicate of #642

See https://github.com/kakaroto/Beyond20/issues/642#issuecomment-1001073349 in particular.

kakaroto commented 2 years ago

As @Aeristoka pointed out, it's just not something that we can do for technical reasons. This is a duplicate of https://github.com/kakaroto/Beyond20/issues/642 in which I replied with more details. The short answer is "either way, it's random"