kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
497 stars 145 forks source link

Add option to use roll renderer with OGL sheet templates #971

Closed flyingitalianman closed 2 years ago

flyingitalianman commented 2 years ago

Is your feature request related to a problem? Please describe. If a weapon has more than 2 damage sources/types/modes, the visualization in Roll20 is messy (see screenshot).

Describe the solution you'd like If more than 2 numbers need to be shown for damage, I would expect new lines to be created, not everything to be crammed in slot #2.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Steps to reproduce the behavior:

  1. be a rogue (sneak attack), lvl 10 arcane trickster
  2. get a flaming rapier (piercing and fire damage)
  3. use booming blade (thunder damage x2) and attack

https://i.imgur.com/1ejEyIL.png

This is what is shown in the Roll20 chat when I do an attack with the above weapon (compounded with a crit): https://i.imgur.com/Rzr7Dhh.png

Aeristoka commented 2 years ago

This isn't something that Beyond20 can fix, as this is just how cramped the templates are on Roll20. Unless @kakaroto can think of some clever way to output into multiple template sections.

flyingitalianman commented 2 years ago

thank you for replying

wouldn't it be possible to send some damages as a separate roll/attack (say, like different magic missile attacks)

it is possible to have only the damage roll without the attack roll, so it could use that interface, no? (I admit I did not look into the code)

Aeristoka commented 2 years ago

The core issue here is: Beyond20 is asking Roll20 to do the roll (with Digital Dice on DnDBeyond disabled), so Roll20 is gonna put things where it will.

With Digital Dice enabled, it slots in slightly differently (I can't recall the exact code portion for that), but it's still an issue of how the template works.

Particularly it's this template: image

You can change that setting to: image

And that will use a different Roll20 Template that displays information in a less "Pretty" but far more readable format.

kakaroto commented 2 years ago

Yeah, the issue is that Roll20 only supports 2 damages, and if there's a crit, it adds it next to it on the same boxes. We could display them all on separate lines, which is what we do if you enable the D&D Beyond digital dice, and that's because we make the rolls ourselves (DDB does actually) so we already know the roll results, we know which dice to take in case of advantage/disadvantage, we know if it was a crit or not, etc.. so we just display them all properly, see this for example : image With sneak attack + dread ambusher + crit : image But if we enable the digital dice, it rolls it like this : image

The problem is that when rolling an attack like that, with Roll20, you don't have much control and have to fit within the boxes they give you.. if we sent multiple damage rolls separately like we do in the second screenshot, then in case of a critical hit, Roll20 would only roll the crit for the first damage, not the others, etc...

One thing we could do is have the option to use the OGL sheet templates but roll using the Beyond20 roll renderer, so you can get the same effect even without the digital dice enabled.

Aeristoka commented 2 years ago

That's actually probably a good idea, it'll clean up a pretty longstanding complaint.

flyingitalianman commented 2 years ago

Thank you for looking into this! And yes, the digital dice option is exactly what I was hoping to get in terms of visualization. I'll use that for the time being.