kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
497 stars 145 forks source link

Bug with 'Add tiebreaker to initiative rolls' #973

Closed IsaacAbramowitz closed 2 years ago

IsaacAbramowitz commented 2 years ago

I'm not sure if this is just for me but there seems to be a problem with the Add tiebreaker to initiative rolls feature. When rolling with it it says NAN and doesn't add any number to the roll even though my characters' initiatives are more than +0. When I turn off the Add tiebreaker to initiative rolls option everything works fine. I've tested this with multiple characters on D&D Beyond, with Roll 20 open and not open, and even uninstalled Beyond 20 then reinstalled it. Same result.

The browser I'm using is Opera

image

Aeristoka commented 2 years ago

This actually isn't due to that setting, but due to a change DnDBeyond made today with how Initiative is stored in the Field here: image

It has been fixed and merged here: https://github.com/kakaroto/Beyond20/pull/972

And we're looking at a release hopefully tonight.

IsaacAbramowitz commented 2 years ago

@Aeristoka hah was just looking now at your PRs and noticed there was one for this exact fix. My bad, next time I'll look there first

Aeristoka commented 2 years ago

@Aeristoka hah was just looking now at your PRs and noticed there was one for this exact fix. My bad, next time I'll look there first

No worries at all 😄 , I definitely don't ALWAYS have a PR in already. Feel free to join us at the Discord too: https://discord.gg/ZAasSVS We're usually discussing bugs, or would love to have reports of future bugs in there too!

Aeristoka commented 2 years ago

Re-opening as a placeholder until the 2.6.3 release

Aeristoka commented 2 years ago

Closing with 2.6.3 being available.