kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
497 stars 145 forks source link

Minor display bug: negative modifiers #991

Closed Ribcourt closed 2 years ago

Ribcourt commented 2 years ago

Describe the bug Rolling to Discord from DndBeyond with a negative modifier, the resolved values are signed positive in Discord. Dice formulas and results are shown correct.

Adding a negative Custom Modifier or negative Custom Damage via hotkey, the resolved dices are signed positive in Discord. Dice formulas and results are shown correct.

Using a homebrew magic weapon with a negativ modifier has the same effect

To Reproduce Steps to reproduce the behavior:

  1. Add a Hotkey with a negative Custom Modifier/Damage
  2. Roll to Discord with Hotkey

Steps to reproduce the behavior:

  1. Create a Homebrew Magic Weapon with a negative modifier
  2. Roll attack to Discord

Expected behavior Resolved Dice should be signed negative.

Browser Info (please complete the following information):

Screenshots Hotkey Discord_Result Weapon Discord_Result_Weapon

kakaroto commented 2 years ago

Good catch, thanks! While this is technically the right repo for the issue, I'll transfer it to the Beyond20 repo instead which is where we do the triage and "milestone-ing" of issues for release. Thanks!

Aeristoka commented 2 years ago

@kakaroto what did you do...

This is pretty funny