kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
497 stars 145 forks source link

Bug with "summon fey" dndbeyond #998

Closed nyxalteria closed 2 years ago

nyxalteria commented 2 years ago

Someone said it may be an issue with beyond20 since I'm using that extension unsure if its a coding issue in dndbeyond or here so I'm posting it to both places.

Summon fey dice rolling for the hp of said fey is not rolling/displaying properly

https://imgur.com/0nKwhJQ

It says this for the statblocks on my character sheet when I open the spell.

https://imgur.com/JCcuRMQ

And it says this when I attempt to roll the dice for the HP. The statblock says 30 HP + an additional +1d10 for each spell slot level above 4th, eg rolling from a 4th level spell slot should result in 30 + 1d10(or is this suppose to be a d20 that's rolled for that? that's not exactly clear), its not resulting in this (either of those results).

Aeristoka commented 2 years ago

@kakaroto have fun with more weird formatting parsing nonsense 😄

nyxalteria commented 2 years ago

spell is official, its from tasha's cauldron of anything if you guys need to take a closer look at it

nyxalteria commented 2 years ago

image I was told this on the dndbeyond forums? so if that's the case then its showing a rollable table for something that shouldn't be rollable

Aeristoka commented 2 years ago

So, you're on sort of the right track, but it's not that it's a "Rollable Table". The issue here is that the Fey Spirit's health is: "30 + 10/spell level above 3rd". DnDBeyond chose to format this like this:

image

Beyond20 then parses, sees a "+ 10" with no particular other Die before it, and based on how DnDBeyond uses that formatting most every other place, we end up with this:

image

Where Beyond20 inserts a roll for "1d20 + 10", because, as I mentioned MOST other places, this is a valid assumption (if there is a + in this style of formatting, it's a 1d20 + roll).

That's why I teased @kakaroto about having to deal with formatting fun, because this is yet another funky edge case to deal with.

nyxalteria commented 2 years ago

Not sure if I should make a new post for this but this is another edge case, its showing the proficiency bonus as rollable image https://www.dndbeyond.com/sources/mcv1/spelljammer-creatures

edit: to tack onto this its likely the same case but skills are showing as rollable as well image https://www.dndbeyond.com/monsters/17100-aarakocra

Aeristoka commented 2 years ago

No, same issue, likely the same cause

kakaroto commented 2 years ago

This one isn't fun, the statblock in those source pages is completely different, would need to rewrite the entire statblock parser 😬

kakaroto commented 2 years ago

Finally fixed! That took wayyyyyyyy too long and involved way too much code changes. I hope nothing broke!