kakaroto / Beyond20

D&D Beyond Character Sheet Integration in Roll20
GNU General Public License v3.0
497 stars 145 forks source link

Add ability to override any global setting on a per-character basis #999

Open Rarst opened 2 years ago

Rarst commented 2 years ago

Is your feature request related to a problem? Please describe. Critical hit rules is one of the best features for me (since D&D Beyond doesn't natively support alternate rules), however it is likely to differ between campaigns and it is a little buried / hard to see current setting.

Describe the solution you'd like

  1. It would make sense if critical hit rules could bet set per campaign (similar to how Character Specific Options are handled)
  2. Alternately just relocating it to the initial tab (e.g. next to Force Critical Hits) would improve visibility and lower mistakes from having a wrong setting for the campaign
Aeristoka commented 2 years ago

So a couple of points here:

There is no "per campaign" setting. Beyond20 has no concept of that, as it is parsing Character sheets/NPC Sheets.

Character Specific are literally that because of what is parsed on that particular character sheet.

"Force Crits" is exposed on the main page of options because it is a core part of the D&D 5e Ruleset (if you attack an unconscious character with a melee attack within 5 feet it is an auto-crit in example).

The Homebrew Critical options are NOT a part of the core D&D 5e Ruleset at all, but they are a thing that @kakaroto included (the most used two that he was aware of when they were added), thus they are buried deeper in the settings as 99% of the time or more, it is 100% unnecessary to change.

All that said, I'll need to discuss this with @kakaroto and see what he thinks.

Rarst commented 2 years ago

as 99% of the time or more, it is 100% unnecessary to change

If all of your games use standard critical rules, it's never necessary to change.

However if even one of your games uses alternate rules, you have to check that before every game or you'll roll wrong stuff and then have to change it and re-roll in the middle of the game.

A more conservative improvement might be to show it prominently if it's set to anything other than standard rules. Same status quo for players with defaults, better experience for players who have to deal with it every time.

kakaroto commented 2 years ago

That's not a setting I'd like to have be per-character, but I do like the idea of having a more generic per-character "override global setting" which would allow you to override the crit rules or any other setting for a specific character (like, use digital dice only for this character, or don't auto roll damages, etc...)

Rarst commented 2 years ago

My thinking was bogged on campaign level for it (because rule is decided by DM on that level), but handling it on character level works too and already has precedent.

However that would makes sense for you, thank you for considering. :)

kakaroto commented 2 years ago

This is turning out to be more complex than I thought, and I just can't imagine how to do it in the user interface. If you have suggestions on how it could be done so the UI is not confusing and the feature is usable, then let me know, until then, I'm bumping it to a future release instead.