search

kakawait / uaa-behind-zuul-sample

Spring AuthorizationServer load balanced behind Zuul
322 stars 156 forks source link

Added support for docker (+docker-compose) #12

Closed bilak closed 7 years ago

bilak commented 7 years ago

Fixes gh-3

kakawait commented 7 years ago

@bilak I already think we should create a maven profile to be able to build whole service with their images

mvn clean install -Pdocker (or -Pcontainer whatever)

using parent pom

kakawait commented 7 years ago

@bilak If you have any trouble with maven configuration (about profile and multi-module) I can help you I already done such configurations for other project

bilak commented 7 years ago

Btw I've only tested if I can get the token. Didn't tested if dummy service works with this token, because I don't work with JWT's so that could be tested by you probably. There are plenty options which we can work on, maybe you can create some checklist.

bilak commented 7 years ago

@kakawait maybe create another issue to don't mess with a lot of commits.

kakawait commented 7 years ago

@bilak yes please only support JWT (default implementation) for this PR and open issue to add other possible options/configurations like without JWT

But don't care about

lot of commits

This project is much more a POC, so I'm less regarding about quality 🍭

kakawait commented 7 years ago

@bilak do you continue working on PR? Else I can polish current and merge it asap

bilak commented 7 years ago

@kakawait sorry currently I don't have time for this.

kakawait commented 7 years ago

@bilak I continue work on #14 Thank you for PR, I used a lot of part for new PR #14

I close this PR in favor to #14