search

kakone / GoogleCast

Implementation of the Google Cast protocol (.NET Standard 2.0 library)
GNU General Public License v3.0
143 stars 22 forks source link

Add support for netstandard2.0 #3

Closed Marcus-L closed 7 years ago

Marcus-L commented 7 years ago

Updated references to latest versions, added multi-targeting for netstandard1.4 and netstandard2.0. Because ASP.NET also uses Microsoft.Extensions.DependencyInjection, the new ASP.NET Core 2.0 targets the netstandard2.0 version of this library, which is incompatible with the 1.x version. Any .NET Core application targeting netcoreapp2.0 and Microsoft.Extensions.DependencyInjection 2.x will not work without this change.

kakone commented 7 years ago

I finally wonder if it's worth keeping .Net Standard 1.4 compatibility. As it doesn't work in UWP for the moment (SslStream is not implemented in UWP), I think we can only support .Net Standard 2.0.

Marcus-L commented 7 years ago

Yeah, I was sorta thinking the same thing. But this was the first time I'd ever done a multi-targeted csproj so it was a good learning experience. If you want me to undo the changes from https://github.com/kakone/GoogleCast/pull/3/commits/398daf3152389bd8e09811c93596e627195fc709 just let me know and I'll send over another PR, or if you want to do it by all means go ahead. Thanks for the great library, it was fun to look through and learn some Cast protocol internals.