Fix the bug that event raises exceptions - Githubissues

kakone / VLC.MediaElement

MediaElement clone powered by VLC

GNU Lesser General Public License v2.1

68 stars 33 forks source link

Fix the bug that event raises exceptions #61

Closed taoyouh closed 6 years ago

taoyouh commented 6 years ago

RoutedEventArgs instances are now constructed with dispatcher to avoid thread faults. (Issue #60)
Some async void functions are renamed from "xxxAsync" to "xxx" because async void functions are not awaitable and does not appear async to caller, making the "xxxAsync" name confusing.

JunielKatarn commented 6 years ago

Does this fix seem related to this issue too? #65.

taoyouh commented 6 years ago

@JunielKatarn This PR fixes similar error, but I am not sure whether your issue can be fixed by this. You can clone my repository and make some tests.

vbfnet commented 6 years ago

I am getting the same error in UWP app when using this package. The "Media Opened", "Media Failed" etc. events are failing because of thread faults.

I believe the changes made taoyouh will fix the threading issues. Is there a way to get the nuget package with the changes included by taoyouh?

Thanks

taoyouh commented 6 years ago

@vbfnet I think the only way to get the nuget package with my changes is that somebody create a new package based on my repository.

vbfnet commented 6 years ago

@taoyouh Thanks for clarifying.

kakone commented 6 years ago

Resolved by 211399e92fe2533a0081cd72601affd6b09c61cb

vbfnet commented 6 years ago

Excellent ! Thanks and will test asap

kakone commented 6 years ago

You can test it with the new NuGet package 3.1.0

vbfnet commented 6 years ago

Yes, No more threading errors for The "Media Opened", "Media Failed" etc.

Great job!