search

kakoune-lsp / kakoune-lsp

Kakoune Language Server Protocol Client
The Unlicense
605 stars 114 forks source link

Add `phpactor` to the default config #761

Open notramo opened 2 months ago

notramo commented 2 months ago

https://github.com/phpactor/phpactor phpactor is an open source PHP language server.

I would recommend making phpactor the default instead of intelephense as the latter is closed source.

krobelus commented 2 months ago

I think it'd be a good idea to switch to a server that has the potential to become the most popular one. I wonder how it compares to others like serenata or php-language-server that are listed here https://emacs-lsp.github.io/lsp-mode/page/lsp-serenata/ for example.

notramo commented 2 months ago

php-language-server last commit was in 2018. Serenata latest release was in 2020, latest commit is 2022.

Meanwhile phpactor is actively maintained, with latest release ~2 weeks ago. It also seems to have more features.

phpactor has integrations with many other PHP code quality tools (Psalm, PHPStan, PHP-CS-Fixer, PHP_CodeSniffer etc).

Psalm also has a language server, but it can also be added to phpactor as a plugin.

krobelus commented 2 months ago

I like phpactor as default. There is an easy-to-trigger bug in diagnostics, reported as https://github.com/phpactor/phpactor/issues/2722

krobelus commented 1 month ago

can anyone who has been using phpactor in prod confirm that it works fine and is not missing too many important features compared to intelephense?