kakounedotcom / connect.kak

Connect a program to Kakoune clients
https://kakoune.org
The Unlicense
88 stars 18 forks source link

Horizontal and Vertical Options #11

Closed robertmeta closed 4 years ago

robertmeta commented 4 years ago

I would love to be able to fire this off in a vertical or horizontal mode.

alexherbo2 commented 4 years ago

connect.kak does not handle the windowing. You should ask for tmux.kak or add a command to position the window.

tmux-terminal-windowtmux-terminal-impl new-window %arg{@}

robertmeta commented 4 years ago

There exists tmux-terminal-vertical and tmux-terminal-horizontal

alexherbo2 commented 4 years ago

Do you see a nice way to make the terminal command in connect.kak configurable?

I’m not sure if it should be addressed here or upstream.

robertmeta commented 4 years ago

Fair point, hmph... Let me consider it, if I come up with a good solution I will submit a PR. I was hoping you would have a great notion!

alexherbo2 commented 4 years ago

It could be nice to be able to tell terminal whether we want the newly created window.

Something like Splitting containers for setting the orientation could be nice for Kakoune.

Maybe ask @occivink also.

occivink commented 4 years ago

At some point the idea of a -split vertical|horizontal parameter to terminal floated around, but it never really got anywhere. What you can do is simply change the terminal alias, like so

define-command connect-vertical %{ 
    alias global terminal tmux-terminal-vertical
    connect 
}
define-command connect-horizontal %{ 
    alias global terminal tmux-terminal-horizontal
    connect 
}

but it sucks a bit that it modifies the global configuration

alexherbo2 commented 4 years ago

How about a split command setting an option, and the terminal implementations doing something with that option?

split (vertical|horizontal|toggle)
robertmeta commented 4 years ago

that would be amazing!

alexherbo2 commented 4 years ago

@occivink Are you op to take care of that request?

alexherbo2 commented 4 years ago

I’m closing, as this issue is more addressed upstream.

alexherbo2 commented 4 years ago

@robertmeta terminal-mode.kak