search

kakounedotcom / connect.kak

Connect a program to Kakoune clients
https://kakoune.org
The Unlicense
88 stars 18 forks source link

editor for tig #5

Closed vbauerster closed 4 years ago

vbauerster commented 4 years ago

It turns out that tig doesn't respect $EDITOR env var, at least I wasn't able to invoke kak with its e command within connect-terminal. Exporting GIT_EDITOR makes tig to invoke internal edit command.

vbauerster commented 4 years ago

Related.

alexherbo2 commented 4 years ago

Can you add a copyright waiver before the first commit and add this variable in overrides instead?

It could eventually go in a git.env, but overrides looks reasonable enough. What do you think?

The branch name and PR do not match what it changes, because the variable is for Git, and not specifically Tig.

vbauerster commented 4 years ago

Ok, I actually put it first in overrides, but it needs export so I decided to separate. GIT_EDITOR env var is specific to tig which tells tig to ignore git core.editor setting, hence the branch name. However I can rename if you propose a different name.

alexherbo2 commented 4 years ago

GIT_EDITOR is a Git environment variable.

Not sure if it’s possible in the same PR to rename the branch.

vbauerster commented 4 years ago

I've made a change.