search

kakwa / ldapcherry

Web UI for managing users and groups in multiple directory services.
MIT License
225 stars 70 forks source link

Update CherryPy Dependency for python2 compatibility #13

Closed Aniem closed 5 years ago

Aniem commented 5 years ago

According to CherryPy's Pypi page, CherryPy does not support Python2 anymore starting in version 18.0.0. Indeed, an error appears at runtime after setting up CherryPy from master.

This PR fixes this problem by enforcing a version < 18.0.0 to CherryPy

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at ?% when pulling 0ac60bd462dc71d8daa5ed0ad14b730d837dcc8f on Aniem:CherryPy-python2-compat into 1ed654c91bf2caeedbad34944bf837b6c21a2292 on kakwa:master.

kakwa commented 5 years ago

Hello, I will try to explore a different route, making this project Python 3 compatible. It was not possible when I first wrote this UI as python-ldap was Python 2 only. but it seems they have added Python 3 support about a year ago.

Aniem commented 5 years ago

It is in fact a better route indeed. However, in the meantime as well as for users that work in a python2 environment, wouldn't it be relevant to merge the PR and put the python2 version into a "legacy-python2" branch even if this branch will no longer be maintained ?

kakwa commented 5 years ago

hello,

the code is now portable between python 2 and python 3.

I indeed restricted the version of cherrypy with < 18.0.0 for python 2 as they dropped python 2 at that version.

for python 3 cherrypy version is unbound.