search

kakwa / ldapcherry

Web UI for managing users and groups in multiple directory services.
MIT License
225 stars 70 forks source link

add more possibility for validation of password #22

Open tburguie opened 5 years ago

tburguie commented 5 years ago

Add possibility to check for a certain number of lower, punctuation characters and a number of rule to check among min_lower, min_upper, min_digit, min_punct.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at ?% when pulling 5b28b68040019c3bab51876268a8075c0849370b on tburguie:master into 245bafb01c4b7f7302667577a7f4f0390f53a9d1 on kakwa:master.

kakwa commented 5 years ago

Hummm,

the ppolicy simple is meant to be... simple, I think it would be a better feat for a more complex ppolicy module such as:

https://github.com/kakwa/ldapcherry-ppolicy-cracklib/blob/master/lcppolicy_cracklib/__init__.py

Also, setting default value might be a good idea:

self.get_param('min_point')

self.get_param('min_point', 0)

Otherwise it will introduce a breaking change in the configuration format.