search

kakwa / ldapcherry

Web UI for managing users and groups in multiple directory services.
MIT License
225 stars 70 forks source link

Fix default handler arguments #24

Closed jqueuniet closed 5 years ago

jqueuniet commented 5 years ago

The default handler is currently failing with the following error on CherryPy 18.1:

ldapcherry.app    - ERROR - [26/Mar/2019:09:19:15]  uncaught exception: [default() takes from 1 to 2 positional arguments but 4 were given]

This PR tries to fix this error.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.9%) to 80.757% when pulling 0a96ca61d541cf2cd76c29a811b82914764e43fc on jqueuniet:fix_default_handler into 3b58f1464e7a1eaf16f0baa97c4d84229e16b152 on kakwa:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.9%) to 80.757% when pulling 0a96ca61d541cf2cd76c29a811b82914764e43fc on jqueuniet:fix_default_handler into 3b58f1464e7a1eaf16f0baa97c4d84229e16b152 on kakwa:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.9%) to 80.757% when pulling 0a96ca61d541cf2cd76c29a811b82914764e43fc on jqueuniet:fix_default_handler into 3b58f1464e7a1eaf16f0baa97c4d84229e16b152 on kakwa:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.9%) to 80.757% when pulling 0a96ca61d541cf2cd76c29a811b82914764e43fc on jqueuniet:fix_default_handler into 3b58f1464e7a1eaf16f0baa97c4d84229e16b152 on kakwa:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.9%) to 80.757% when pulling 0a96ca61d541cf2cd76c29a811b82914764e43fc on jqueuniet:fix_default_handler into 3b58f1464e7a1eaf16f0baa97c4d84229e16b152 on kakwa:master.

kakwa commented 5 years ago

Indeed something is a bit off on the default page (I've noticed some issues myself when porting to python 3). I will probably include this fix, but I need to check it doesn't break anything with older versions of cherrypy (specially those used for CentOS 7 and Debian 9)