Closed smacz42 closed 5 years ago
Thank you for the PR, but unfortunately, I'm going to reject this PR for various reasons:
CherryPy==17.3.0
. The reason being that I prefer to provoke a clean break instead having my users install obsolete and potentially insecure dependencies. I tried to chose the dependencies of ldapcherry carefully, with projects being cautious about breaking APIs (cherrypy has been quite good at it until now). I also try to target stable versions of mainstream distributions (Debian and CentOS/RHEL).Lastly, I'm not comfortable in having to maintain these additional items (keep in mind ldapcherry is a personal project I maintain on my spare time).
I'm sorry to reject it, but keep in mind every PR is welcomed. Even if not integrated, it can lead to changes that are interesting, for example if you have suggestion around making ldapcherry more "Docker compatible", it is welcomed.
The environment is set up in the Dockerfile. The
/etc/ldapcherry/ldapcherry.ini
file is able to be either used regularly (which is exposed as a volume) or configured with environment variables that are passed to the container at runtime. This is done using theinit.py
script, which kicks off the mainldapcherryd
process after setting up the conf file.This is all done with python2, with an eye to migrating it to python3 when the application changes have been made.