kakwa / ldapcherry

Web UI for managing users and groups in multiple directory services.
MIT License
225 stars 70 forks source link

Dockerize LdapCherry #26

Closed smacz42 closed 5 years ago

smacz42 commented 5 years ago

The environment is set up in the Dockerfile. The /etc/ldapcherry/ldapcherry.ini file is able to be either used regularly (which is exposed as a volume) or configured with environment variables that are passed to the container at runtime. This is done using the init.py script, which kicks off the main ldapcherryd process after setting up the conf file.

This is all done with python2, with an eye to migrating it to python3 when the application changes have been made.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.9%) to 80.757% when pulling 43c118251da705da3ae4fe142825085cebadda35 on smacz42:andrewcz-homelab-179 into 3b58f1464e7a1eaf16f0baa97c4d84229e16b152 on kakwa:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.9%) to 80.757% when pulling 43c118251da705da3ae4fe142825085cebadda35 on smacz42:andrewcz-homelab-179 into 3b58f1464e7a1eaf16f0baa97c4d84229e16b152 on kakwa:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.9%) to 80.757% when pulling 43c118251da705da3ae4fe142825085cebadda35 on smacz42:andrewcz-homelab-179 into 3b58f1464e7a1eaf16f0baa97c4d84229e16b152 on kakwa:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.9%) to 80.757% when pulling 7317ebdd23c3060e26305b53866872a23e14826e on smacz42:andrewcz-homelab-179 into 3b58f1464e7a1eaf16f0baa97c4d84229e16b152 on kakwa:master.

kakwa commented 5 years ago

Thank you for the PR, but unfortunately, I'm going to reject this PR for various reasons:

Lastly, I'm not comfortable in having to maintain these additional items (keep in mind ldapcherry is a personal project I maintain on my spare time).

I'm sorry to reject it, but keep in mind every PR is welcomed. Even if not integrated, it can lead to changes that are interesting, for example if you have suggestion around making ldapcherry more "Docker compatible", it is welcomed.