search

kakysha / HonorSpy

World of Warcraft: Classic HonorSpy addon
57 stars 50 forks source link

Name column: show only first letter of Realm name #183

Closed teelolws closed 2 years ago

teelolws commented 2 years ago

For: https://github.com/kakysha/HonorSpy/issues/179

Also: added sorting alphabetically by Name, and fixed an issue with sorting by Standing sorting randomly if all characters had the same honor last week.

teelolws commented 2 years ago

No I reverted that one, I just couldn't remove it from my fork history without deleting and recreating it. https://github.com/kakysha/HonorSpy/pull/183/commits/6322d57ef90618ccfaa387dae56e7eebd4ab0b6b

kakysha commented 2 years ago

Conflicts :( I'm merging in the order of my github notifications :D Also, why only first letter? No space? Can we actually just make the name occupy the whole width of the column and ellipsis it if it doesn't fit? Truncating player name when there is space left (for short names for example) looks ugly.

teelolws commented 2 years ago

Simplest solution. "IlIlIlIlIl" would fit while "WWMWWMWWMW" wouldn't and its too complicated to detect a distinction like that.

kakysha commented 2 years ago

Merged this, though I would have made a bit more complex calculation on player names width (at least approx...) so it takes at least the whole column width for short names. Thanks anyway!

Slivo-fr commented 2 years ago

Merged this, though I would have made a bit more complex calculation on player names width (at least approx...) so it takes at least the whole column width for short names. Thanks anyway!

I will take a quick loot at this. Is there any release planned ?