search

kakysha / HonorSpy

World of Warcraft: Classic HonorSpy addon
57 stars 50 forks source link

Duplicated player entry in table #184

Closed Slivo-fr closed 2 years ago

Slivo-fr commented 2 years ago

As you can see on this picture, 2 and 3 is the same player. Same for 6 and 7. Those data come from a level 1 char, alone on it's account, and never entered a BG. Most likely received it on com from another player. Those duplicated players are from my own server if that somehow helps

image

Slivo-fr commented 2 years ago

Maybe we lack a realm check and strip somewhere ?

teelolws commented 2 years ago

Its the same issue from https://github.com/kakysha/HonorSpy/issues/175 which you even replied to.

There is something screwed up on Blizzards end which is making a player on another realm show up in-game as if they're from your realm. Because its so rare, I can't catch when it happens. Because I can't see it happen live, I can't find a workaround.

The good news: it only seems to happen once. From next week onwards you shouldn't see those players duplicated again.

Slivo-fr commented 2 years ago

I didn't think those would be linked, as it's only legits players from my cluster on this one. Let me know if I can help somehow

teelolws commented 2 years ago

@kakysha assuming the fix I published worked, we're probably still going to get bad data from players who are slow to update HonorSpy. Do you think I should bump the Comm Prefix from 4 to 5, to discard data from players on old versions of the addon?

kakysha commented 2 years ago

Yep, let's do this

teelolws commented 2 years ago

Lets wait until Monday. I don't want to break addon comms when the week has already started (on US).

Slivo-fr commented 2 years ago

Isn't it better to break coms early than late in the week ?

teelolws commented 2 years ago

PR for comm prefix and some other changes up: https://github.com/kakysha/HonorSpy/pull/187

Slivo-fr commented 2 years ago

Not fixed, I'll try to debug that !

Slivo-fr commented 2 years ago

Looks solved in 1.8.7 will close after some more testing

Slivo-fr commented 2 years ago

This issue seems fully resolved :D