kakysha / HonorSpy

World of Warcraft: Classic HonorSpy addon
57 stars 50 forks source link

Report buttons and connected realms #185

Closed Slivo-fr closed 2 years ago

Slivo-fr commented 2 years ago

When reporting a player from another server on the same ERA cluster using the GUI report button, HonorSpy try to report the same name from my original server and do not find it.

image

teelolws commented 2 years ago

Try this and lmk if it works. I don't have any data to test it with yet: https://github.com/kakysha/HonorSpy/pull/183/commits/8f269d685e72e60fc572cdccf2f38e1a19b81ce8

Slivo-fr commented 2 years ago

Bit better but still not working

image

teelolws commented 2 years ago

I'll make that check case-insensitive.

Slivo-fr commented 2 years ago

The minimap middle mouse click has also the same issue by the way !

Slivo-fr commented 2 years ago

And /hs search Silverdragon-Finkle is broken too

HonorSpy: Player Silverdragon-finkle not found in table

teelolws commented 2 years ago

Heres the problematic code, in HonorSpy.lua:

playerOfInterest = string.utf8upper(string.utf8sub(playerOfInterest, 1, 1))..string.utf8lower(string.utf8sub(playerOfInterest, 2))

teelolws commented 2 years ago

Okay try this: https://github.com/kakysha/HonorSpy/pull/183/commits/4cc6ddf554e0c1db01fd96262a3373dbe48a928d

Slivo-fr commented 2 years ago

Works for search and report button, minimap middle click still lacks the realm

teelolws commented 2 years ago

Should fix the minimap middle click: https://github.com/kakysha/HonorSpy/pull/183/commits/68fa44bc001043f38979092224333b6b060cb7b0