search

kakysha / HonorSpy

World of Warcraft: Classic HonorSpy addon
57 stars 50 forks source link

CommPrefix bump to 5 + others #187

Closed teelolws closed 2 years ago

teelolws commented 2 years ago

Please don't release this midweek. If you can't accept the PR and tag a release before tomorrow (Thursday) please wait until Monday. I don't want to have a mess of half-updated players over the weekend to deal with.

In world pvp, the chatlog was showing messages like "Enemyplayer died, honorable kill 5" even if Enemyplayer was actually on another server. This means the kill counter was being saved under Enemyplayer-Arugal when it should be saved under Enemyplayer-Yojamba. I can get their realm from the UNIT_DIED subevent of the COMBAT_LOG event, and store it in a cache. This isn't 100% if there are two players with the same name from different realms both doing pvp at the same time. But that should be niche enough to not matter.

Also made a bunch of functions local that were leaking into the global namespace. If testing becomes a problem later on I might shove them into the HonorSpy: namespace instead.

kakysha commented 2 years ago

Merged. So when is the best time time to release the update? Today I suppose?

teelolws commented 2 years ago

Monday.