search

kakysha / HonorSpy

World of Warcraft: Classic HonorSpy addon
57 stars 50 forks source link

GUI doesn't display every character #188

Closed Slivo-fr closed 2 years ago

Slivo-fr commented 2 years ago

As you can see, 36 players are known by Honorspy but I can only scroll to the 32th This is related to the number of "bracket" row displayed on the screen I believe

image

Slivo-fr commented 2 years ago

I may be able to provide a fix, testing in progress

Slivo-fr commented 2 years ago

As we reverted it, this issue should be reopened to discuss the potential implementation. Can you please do that ? :)

Slivo-fr commented 2 years ago

I can push another implementation that should not cause any issue, but will leave few empty spaces at the bottom of the table. What do you think about it ? (The number of empty space is equal to the number of bracket separator that could be displayed, they are the same height as other buttons)

image

It's better than having the last rows hidden in my opinion

teelolws commented 2 years ago

Yeah I don't think anyone is going to care about empty rows at the bottom. Fine with me.