Closed Slivo-fr closed 2 years ago
You should merge this into your other fork first, then PR it here. just let it join the PR for your other fork.
I found an issue, working on it, do not merge yet !
There, added a check to prevent a lua error. Let me test this properly, I'll leave a message when it's done
We should be fine now :)
I've added the bit related to the GUI change I made, I don't feel comfortable to push the other changes. Could you please open a separate PR for the sorting part? It would be easier to review
If I make a PR it will create conflicts that I can't resolve during the hours you can.
Why would it ? I didn't alter the code you are modifying for sorting
wtf is going on with this diff? It says the entire file changed? https://github.com/Slivo-fr/HonorSpy/commit/0459a1a635a6ec2a07b939a1a20983a1572e7131
Indeed, it looks like there is some spacing issues, I will fix that tomorrow
Eh leave it. But here is the diff with ignore-whitespace-changes:
@kakysha any chance to get this reviewed / merged / released with the com bump so we can monitor if the #175 is fixed please ?
Thanks a lot :)
Fixes #171
Also adds a toggle setting for estTodayHonor and fix sorting