search

kakysha / HonorSpy

World of Warcraft: Classic HonorSpy addon
57 stars 50 forks source link

Fix GUI honor values #190

Closed Slivo-fr closed 2 years ago

Slivo-fr commented 2 years ago

Fixes #171

Also adds a toggle setting for estTodayHonor and fix sorting

teelolws commented 2 years ago

You should merge this into your other fork first, then PR it here. just let it join the PR for your other fork.

Slivo-fr commented 2 years ago

I found an issue, working on it, do not merge yet !

Slivo-fr commented 2 years ago

There, added a check to prevent a lua error. Let me test this properly, I'll leave a message when it's done

Slivo-fr commented 2 years ago

We should be fine now :)

Slivo-fr commented 2 years ago

I've added the bit related to the GUI change I made, I don't feel comfortable to push the other changes. Could you please open a separate PR for the sorting part? It would be easier to review

teelolws commented 2 years ago

If I make a PR it will create conflicts that I can't resolve during the hours you can.

Slivo-fr commented 2 years ago

Why would it ? I didn't alter the code you are modifying for sorting

teelolws commented 2 years ago

wtf is going on with this diff? It says the entire file changed? https://github.com/Slivo-fr/HonorSpy/commit/0459a1a635a6ec2a07b939a1a20983a1572e7131

Slivo-fr commented 2 years ago

Indeed, it looks like there is some spacing issues, I will fix that tomorrow

teelolws commented 2 years ago

Eh leave it. But here is the diff with ignore-whitespace-changes: image

Slivo-fr commented 2 years ago

@kakysha any chance to get this reviewed / merged / released with the com bump so we can monitor if the #175 is fixed please ?

Slivo-fr commented 2 years ago

Thanks a lot :)