kakysha / HonorSpy

World of Warcraft: Classic HonorSpy addon
57 stars 50 forks source link

Faulty weekly reset from someone that doesn't PvP this week will mess with data #192

Closed Slivo-fr closed 2 years ago

Slivo-fr commented 2 years ago

When a players login after weekly reset, with a failed blizz weekly update, honorspy will broadcast the previous week values to other players. Later, when the weekly blizz update is finaly rolled out, if this players hasn't done any PvP, inspecting will remove it from table but other players will sent back the wrong value again and it will eventually get re-added.

Those edge case may affect the natural pool count and could interfere with estimate/bracket if enough honor was made on the previous week.

I can't think of a way to handle this

Slivo-fr commented 2 years ago

Here is an idea :

Doing this, the player will still show in honorspy, but at least it won't stay at last week honor for the whole week. Any thought ?

Slivo-fr commented 2 years ago

Considering the uncommented code from https://github.com/kakysha/HonorSpy/pull/210

We could also keep a defined delay past the weekly reset before storing players to avoid storing failed resets at all Let's say 6 hours for example ?

Slivo-fr commented 2 years ago

Another idea would be rejecting any player with any "knownHonor" until 24h (or less?) after the weekly reset, should be enough to filter the bad resets without rejecting valid players !

I kinda like this idea, any opinion ?