Closed Slivo-fr closed 2 years ago
Nah cause if the inspect fails and inspect data is never received, the addon will be stuck never inspecting anyone else until the next reload.
Negative, because of the last_inspect_time check, we start again after 1s if the event doesn't fire (It wasn't properly implemented before my last push)
fix formatting a bit with obsolete newlines etc.
There, I may have a tab/spacing issue with my IDE
I think he means make it more like
` if (
paused or
(not C_PlayerInfo.UnitIsSameServer(PlayerLocation:CreateFromUnit(unitID))) or
currentlyInspecting or
((GetTime() - lastInspectTime) < 1)
) then
`
@teelolws this snippets is outdated, I've updated the implementation since then (I forced push, check https://github.com/kakysha/HonorSpy/pull/201/files)
My post is still relevant to that.
We discussed it on discord, all good
In order to try to solve #198
This is a draft to discuss. Please do not merge it needs further testing.