search

kakysha / HonorSpy

World of Warcraft: Classic HonorSpy addon
57 stars 50 forks source link

Adds compression, encoding and length check on comms messages #205

Closed Slivo-fr closed 2 years ago

Slivo-fr commented 2 years ago

Fix #198 Fix #142

Here is a first draft, feel free to review

teelolws commented 2 years ago 
if (HonorSpyUtils:getCompleteName(sender) == playerName) then return end

Make sure that works on realms with spaces in the name.

teelolws commented 2 years ago

Other than that (and the debugging prints), it all looks good to me. We hopped on the PTR and tested it, seems to work well.

Slivo-fr commented 2 years ago

Make sure that works on realms with spaces in the name.

Tested, does works !

Slivo-fr commented 2 years ago

I'm done with everything I was working on. You may release a new version once we rejected/merged open merge requests