search

kalaiser / awesome-cdk

A collection of awesome things related to the AWS Cloud Development Kit (CDK)
Creative Commons Zero v1.0 Universal
1.99k stars 195 forks source link

feat(p6-barrier): adds link to Ops #73

Closed pgollucci closed 3 years ago

pgollucci commented 3 years ago

CDK Construct Custom Resource which will poll until an AWS Lambda Function isReady returns true and it is ideal for running code AFTER an RDS or EKS is ready.

kolomied commented 3 years ago

It is a cool concept you are trying to build here. However I'm confused with the implementation and therefore hesitant to include the link to the list.

Barrier itself it implemented by dependencies on SSM parameter and CFN ensures the correct order of creation. I do not understand the current implementation of a custom resource - it seems that you invoke provided lambda asynchronously and do not check the result it returns. From my reading of the code, lambda function does not have any effect on barrier behavior.

Am I missing something here?

kolomied commented 3 years ago

Going to close for now as there is no activity on the ticket. Feel free to reopen with additional comments.