search

kalaksi / docker-tinyproxy

Docker container for Tinyproxy
MIT License
65 stars 24 forks source link

Please add BasicAuth env variable support #7

Closed denis-domanskii closed 1 year ago

denis-domanskii commented 1 year ago

Thank you for the project!

I think it will be important to add BasicAuth env variable. Yes, it's possible to setup it via the mounted config file, but BasicAuth is a mandatory thing because the web proxy can be accessed by anyone on the web, which can be easily abused and is very dangerous.

BasicAuth description: https://tinyproxy.github.io/#BasicAuth

kalaksi commented 1 year ago

Yeah, that's a good idea. Changes seem good. I'll test it a bit later and merge after that.

kalaksi commented 1 year ago

Thanks for the contribution! I also added support for secrets-files.