kalamuna / drupal-project

Kalamuna composer template for Drupal projects with CircleCI and Pantheon integration. (NOTE: THIS SHOULD NOT BE USED FOR NEW DRUPAL 9 SITES)

GNU General Public License v2.0

6 stars 1 forks source link

Merge latest from SoD, plus other improvements #47

Closed hawkeyetwolf closed 6 years ago

hawkeyetwolf commented 6 years ago

@soniktrooth, I need to get with you to review package.json and kalastatic.yml, as we both made changes and I favoured mine for now but want your input. Thanks!

hawkeyetwolf commented 6 years ago

Alrighty @RobLoach, I think she's ready to go. What do you think?

RobLoach commented 6 years ago

What do you think?

Looks pretty good! Sent up two small PRs: https://github.com/kalamuna/drupal-project/pull/49 https://github.com/kalamuna/drupal-project/pull/50

After that, think she's good! We could also fix those after merge, either is good.

hawkeyetwolf commented 6 years ago

50 merged, question for you on #49.