kalamuna / drupal-project

Kalamuna composer template for Drupal projects with CircleCI and Pantheon integration. (NOTE: THIS SHOULD NOT BE USED FOR NEW DRUPAL 9 SITES)
GNU General Public License v2.0
6 stars 1 forks source link

Theme integration and compiling on deployment #69

Open RobLoach opened 5 years ago

RobLoach commented 5 years ago

Create a theme that builds off of classy.

mikemccaffrey commented 4 years ago

I created a repository for the new wireframe theme I plan on creating based on the design teams new wireframe system, and maybe we can use it for this: https://github.com/kalamuna/wireframe

My question is how to best include it as a starter theme within a new drupal project. Base themes are messy, so I'd just like the theme to be copied locally and renamed according to the project name. However, since we don't know what the project name will be, it is hard to set up the rest of the automation.

Any thoughts on the best way to automate that process? And where do we want the node requirements to live, in the drupal-project root, or in the theme directory? Can we write a npm it function that looks in the custom theme directory and then calls npm it on each one in turn?

mikemccaffrey commented 4 years ago

I've added the node requirements and build process to the theme itself, so it can work as a standalone system without needing to be compiled by drupal-project: https://github.com/kalamuna/wireframe-starter/blob/master/package.json

That means we might not need a package.json file in the drupal-project root, unless there is something else we need node for when building a drupal site. We could just have composer trigger the npm install in the theme directory when composer installs.

Make sense?