search

kalamuna / drupal-project

Kalamuna composer template for Drupal projects with CircleCI and Pantheon integration. (NOTE: THIS SHOULD NOT BE USED FOR NEW DRUPAL 9 SITES)
GNU General Public License v2.0
6 stars 1 forks source link

Patches file patch #91

Open enotick opened 3 years ago

enotick commented 3 years ago

@mikemccaffrey we use patches file on a lot of our projects and it seems that it keeps composer.json cleaner. Please review, I think it would be nice to add.

mikemccaffrey commented 3 years ago

I would worry about this implementation, since it seems like it would make patches less obvious. We want to make sure people see and review the patches every time the go to update the modules on the site in order to see if they are still needed.

enotick commented 3 years ago

I would worry about this implementation, since it seems like it would make patches less obvious. We want to make sure people see and review the patches every time the go to update the modules on the site in order to see if they are still needed.

Most of our projects already use it, they were setup before me joining and this is considered the way to go in the community. Composer will tell you if the patch isn't needed anymore during every update, it doesn't matter where the patches are listed. It makes composer.json cleaner and easier to read.