kalamuna / kalastack

Local development environment for drupal
Other
43 stars 21 forks source link

Notice: Undefined index: root in /usr/share/kalaaliases/index.php on line 25 #77

Open pirog opened 10 years ago

pirog commented 10 years ago

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/3956087-notice-undefined-index-root-in-usr-share-kalaaliases-index-php-on-line-25?utm_campaign=plugin&utm_content=tracker%2F235881&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F235881&utm_medium=issues&utm_source=github).
whastings commented 10 years ago

Looks like Pantheon is no longer including the 'root' => '.' entry in alias files. @reynoldsalec has found that this causes issues with running any Drush commands against sites on Pantheon, and he's posted a notice to the Pantheon engineering discussion group.

pirog commented 10 years ago

Pretty sure this is already fixed in head

On Tuesday, December 10, 2013, Will Hastings wrote:

Looks like Pantheon is no longer including the 'root' => '.' entry in alias files. @reynoldsalec https://github.com/reynoldsalec has found that this causes issues with running any Drush commands against sites on Pantheon, and he's posted a notice to the Pantheon engineering discussion group.

— Reply to this email directly or view it on GitHubhttps://github.com/kalamuna/kalastack/issues/77#issuecomment-30257921 .

Cheers,

Mike Pirog Kalamuna www.kalamuna.com

whastings commented 10 years ago

I know we fixed the error it was causing in aliases.kala, but I think it still causes issues with running regular drush commands against a Pantheon environment. I think we should see what Pantheon has to say about it, but I wanted to note it here since it's related.

pirog commented 10 years ago

sounds good. if you guys could open an issue in terminus that is probably the best way to get a response from jp.

On Tue, Dec 10, 2013 at 2:52 PM, Will Hastings notifications@github.comwrote:

I know we fixed the error it was causing in aliases.kala, but I think it still causes issues with running regular drush commands against a Pantheon environment. I think we should see what Pantheon has to say about it, but I wanted to note it here since it's related.

— Reply to this email directly or view it on GitHubhttps://github.com/kalamuna/kalastack/issues/77#issuecomment-30261613 .

Cheers,

Mike Pirog Kalamuna www.kalamuna.com

reynoldsalec commented 10 years ago

Comments from the Pantheon folks regarding the removal of "root":

FROM JOSH: Turns out that a relative path there was a "worst practice" according to Drush, and a blocker for us getting upgrades through on the platform side.

If you have an issue with bootstrapping, the first thing to check is if you are running from inside a local drupal installation. I've seen that create problems.

On the remote side we drop the "user" into the working directory for Drupal, which should be picked up by most commands.

FROM JON:

Upgrading to Drush 5.10.0 locally should help if you're not already on that version.

I've reported at least one Drush 5.10.0 bug that's been deemed a won't fix because it's pretty low-level and it's fixed in Drush 6 :-(

I'm actively working on testing the Drush 6.1.0 upgrade on the Pantheon platform to make sure that nothing breaks.

If you're using drush rsync, our recommended syntax is to include the -r . for that specific command. Without it, drush will use the local alias's site root on the remote site, which, well, doesn't work. http://helpdesk.getpantheon.com/customer/portal/articles/411388#rsync

pirog commented 10 years ago

This is very helpful.

@reynoldsalec, does this ONLY impact sites ON pantheon or local kalabox sites as well? Steps to replicate the issue?

reynoldsalec commented 10 years ago

@pirog

This is only for when you run remote commands using the Pantheon aliases from a local Drupal installation on your Kalabox. If I'm in /var/www/kalamuna and I try running "drush @pantheon.kalamuna.dev pm-list", it'll throw the error in the issue description. Running the same command from /var/www will work, or if you attach a --root flag with the location of the Drupal install on Pantheon.

You can see the thread with Pantheon for the backstory from their end: https://groups.google.com/a/getpantheon.com/forum/#!topic/engineering-talk/Dkylyd2KorE

Sounds like this will (hopefully) get resolved upstream in Drush, according to Josh, but for the meantime it's kind of confusing for folks.

pirog commented 10 years ago

do you have a proposed resolution that we can use on our end?

On Wed, Dec 11, 2013 at 3:45 PM, reynoldsalec notifications@github.comwrote:

@pirog https://github.com/pirog

This is only for when you run remote commands using the Pantheon aliases from a local Drupal installation on your Kalabox. If I'm in /var/www/kalamuna and I try running "drush @pantheonhttps://github.com/pantheon.kalamuna.dev pm-list", it'll throw the error in the issue description. Running the same command from /var/www will work, or if you attach a --root flag with the location of the Drupal install on Pantheon.

You can see the thread with Pantheon for the backstory from their end: https://groups.google.com/a/getpantheon.com/forum/#!topic/engineering-talk/Dkylyd2KorE

Sounds like this will (hopefully) get resolved upstream in Drush, according to Josh, but for the meantime it's kind of confusing for folks.

— Reply to this email directly or view it on GitHubhttps://github.com/kalamuna/kalastack/issues/77#issuecomment-30362000 .

Cheers,

Mike Pirog Kalamuna www.kalamuna.com

reynoldsalec commented 10 years ago

Can we patch Drush on Kalastack with the update Josh mentions in the Engineering Talk thread? At the very least we should document this somewhere, although Pantheon users should all be experiencing this issue on any platform, not just Kalastack-driven stuff.

pirog commented 10 years ago

I'll look into it and get back to you guys