search

kalamuna / kss-bootstrap

:b: A KSS Template and Styleguide for Bootstrap.
http://kalamuna.github.io/kss-bootstrap
Other
13 stars 2 forks source link

Revise presentation of Typography section #20

Closed andrewmallis closed 8 years ago

andrewmallis commented 9 years ago

at http://test-kalastatic.at.kalamuna.com/styleguide/section-1.html we say under the typography heading:

"Use any of the available button classes to quickly create a styled button."

This doesn't line up with http://getbootstrap.com/css/#type-headings

We're actually missing quite a bit here and are perhaps oversimplifying this section…

The visual hierarchy is also broken in absence of the panel/label around the example here and we may be introducing confusion in an effort to remove cruft.

style_guide

RobLoach commented 9 years ago

Three different things......

1. Breaks visual hirarcy

Remove Heading 1?

2. Typography Description

"The below provides typographical styles that are present across the entire site."?

3. This doesn't line up with http://getbootstrap.com/css/#type-headings

Think we should move the Typography section over to the CSS section?

RobLoach commented 8 years ago
  1. Breaks visual hirarcy

This is desired, since we're showing how h1 looks.

  1. Typography Description

Fixed.

  1. Doesn't line up with Bootstrap docs.

Fixed in https://github.com/kalamuna/kss-bootstrap/pull/28