search

kalamuna / kss-bootstrap

:b: A KSS Template and Styleguide for Bootstrap.
http://kalamuna.github.io/kss-bootstrap
Other
13 stars 2 forks source link

Why is the template in a folder called bootstrap? #23

Open thiagodemellobueno opened 8 years ago

thiagodemellobueno commented 8 years ago

A bit confusing, and arbitrary.

RobLoach commented 8 years ago

Rename to "bootstrap-template", or something?

thiagodemellobueno commented 8 years ago

well its just a template, I think “template” would be the right thing all the bootstrap stuff is in another folder “styleguide"

The only appropriate thing to call bootstrap would be bootstrap (and thats why its called bootstrap).

JohnAlbin commented 8 years ago

bootstrap-template or just template

RobLoach commented 8 years ago

My thinkin' too... Got some docs about it in https://github.com/kalamuna/kss-bootstrap#usage ...

@madeofpeople Think we should rename it to bootstrap-template?

thiagodemellobueno commented 8 years ago

Sure.

On Feb 3, 2016, at 6:30 PM, Rob Loach notifications@github.com wrote:

My thinkin' too... Got some docs about it in https://github.com/kalamuna/kss-bootstrap#usage https://github.com/kalamuna/kss-bootstrap#usage ...

@madeofpeople https://github.com/madeofpeople Think we should rename it to bootstrap-template?

— Reply to this email directly or view it on GitHub https://github.com/kalamuna/kss-bootstrap/issues/23#issuecomment-179529488.

RobLoach commented 8 years ago

Renaming would cause upgrade errors, and require us to up a major version. We'd need need to update all references to the template folder from bootstrap to bootstrap-template. Lower priority than the other issues in here.

RobLoach commented 8 years ago

Going to propose removing the Bootstrap template entirely. Possible alternatives:

  1. Move what we've done to the Twig Builder directly in KSS (push it to the upstream)
  2. Split the template off into its own template to make usage easier, and clean up dependencies

Thoughts?

thiagodemellobueno commented 8 years ago

We should repackage this as only the bootstrap definitions, and remove the kss-template parts of it to make it play nice with any builder/template. Then any KSS styleguide could ingest it (if they point to it in kss-node.json). ... oh wait, thats what you said ↑