search

kalamuna / playbox

A playground for ambitious would-be code artists.
http://live-playbox.at.kalamuna.com/
GNU General Public License v2.0
5 stars 29 forks source link

47 continuity of government #107

Closed litwol closed 9 years ago

litwol commented 9 years ago

Strictly speaking this pull request satisfies requirement from #47.

I worked within constraints of overall site engineering and consider current solution to #47 a working but unfortunate hack.

Ideal solution would be this: Battle theming should be a self-contained implementation and separate from the battle+president+robot retrieval logic as is done now in "Playbox Battles" view.

In this scenario to satisfy requirement of #47 one would need to only override a controller which loads president to swap president for VP. leaving the rest of the site implementation untouched (because loaded president would be swapped to VP globally).

reynoldsalec commented 9 years ago

Thanks @litwol, this was a good proof-of-concept. Didn't get it to work on my local (I think the field for associating the president/vice president wasn't created, even after making that it looked like the field swapping wasn't working), but was able to follow the code and was impressed by the speed you cranked that out!

Going to close that out for right now, but feel free to open back up and hammer on it in the future. Hope all is well!