search

kalamuna / playbox

A playground for ambitious would-be code artists.
http://live-playbox.at.kalamuna.com/
GNU General Public License v2.0
5 stars 29 forks source link

settings.local.php configuration override #108

Closed shellshocked59 closed 9 years ago

shellshocked59 commented 9 years ago

I'd like to enable support for overriding settings.php with a settings.local.php on boxes. This type of overriding is something I've always liked for enabling a non-version-controlled file to hold database and other configuration changes for local environments.

You can see a longer discussion on this feature here: https://www.drupal.org/node/1118520. Alternatively if you have a preferred alternative to this solution for local configuration I could use that.

pirog commented 9 years ago

this seems pretty reasonable to me. only small comment would be do you think it should settings.local.php or local.settings.php? mention this only because we have a precedent with default.settings.php

shellshocked59 commented 9 years ago

Sounds good, I updated the branch to include the new filename. I also added a default.local.settings.php file that explains the purpose of the file, and can be copied for developers to create their own local.settings.php files from a template.

Do I need to submit a new pull request to get the new commit in?

pirog commented 9 years ago

Oh nice! Good call on the default file.

You can just push more commits to this branch and they'll get added to this PR.

pirog commented 9 years ago

which it looks like you already did! @reynoldsalec can take it from here!

reynoldsalec commented 9 years ago

Looks good to me on my Kalabox, merging in!