kalamuna / playbox

A playground for ambitious would-be code artists.
http://live-playbox.at.kalamuna.com/
GNU General Public License v2.0
5 stars 29 forks source link

#38: "Other Battles" view #114

Closed proofoftom closed 8 years ago

proofoftom commented 9 years ago

38 Added Other Battles view to Battles page and themed as a grid for desktop width to give it less attention than the Featured Battle. This isn't the case for tablet resolution or smaller though, so some direction could be useful there on the best way to proceed. Another feature that would be useful but may warrant a new ticket is removing the Featured Battle result from the Other Battles results.

reynoldsalec commented 9 years ago

It looks like this update breaks the JS voting widgets; when you click on one widget, the widget disappears and it looks like your vote went to one of the other battles on the screen (although if you refresh it looks like the vote was correctly counted).

Looks like this is an inherent issue with how the counters work; if you take a look at playbox_battles_vote, the function that the AJAX endpoint executes, the replace value assumes there will only be one "battle" on a page. @tommycox, you want to take a crack at that or should we update the original issue and wait for some other intrepid soul to come along and finish this puppy off?

RE: Mobile styling I feel like just making these "Other Battles" smaller would be sufficient, although we should keep the basic design pattern laid out by the featured battle of both contenders being shown on a separate line in the one-column view.

RE: Featured battle results in other battle Created a new issue for this: #116

proofoftom commented 9 years ago

The mentioned issues should be resolved:

Ready for review.