kalamuna / playbox

A playground for ambitious would-be code artists.

http://live-playbox.at.kalamuna.com/

GNU General Public License v2.0

5 stars 29 forks source link

logo added link #57

Closed patrickho81 closed 9 years ago

patrickho81 commented 9 years ago

doing the below issue, and testing out github

In the pane that talks about kalamuna the logo should link to the kalamuna website easy

54

pirog commented 9 years ago

Hey @patrickho81! This is great. The only suggestion i might add is generally you will want to either git assume-ignore or git ignore the settings.php file completely so you are not messing up other peoples database configuration. Make that change and i'll run the merge!

You are also the first to contrib so congrats!!!

patrickho81 commented 9 years ago

Hi, I removed the settings.php file, do I need to start a new pull request for this?

pirog commented 9 years ago

great question! as long as you are committing and pushing to the same branch your new code will get added to this PR. If you refresh the page you should see the new commits.

pirog commented 9 years ago

Another comment here too is you don't want to completely remove settings.php since that will also remove it for other people pulling this code in which will cause their Drupal sites to break. You may want to checkout the HEAD version of settings.php

git checkout HEAD sites/default/settings.php

And then investigate either of these options http://gitready.com/intermediate/2009/02/18/temporarily-ignoring-files.html http://git-scm.com/docs/gitignore

Great work!

pirog commented 9 years ago

This looks good! I've added some supplemental issues to this as well https://github.com/kalamuna/playbox/issues/60