Closed patrickho81 closed 9 years ago
Hey @patrickho81! This is great. The only suggestion i might add is generally you will want to either git assume-ignore or git ignore the settings.php file completely so you are not messing up other peoples database configuration. Make that change and i'll run the merge!
You are also the first to contrib so congrats!!!
Hi, I removed the settings.php file, do I need to start a new pull request for this?
great question! as long as you are committing and pushing to the same branch your new code will get added to this PR. If you refresh the page you should see the new commits.
Another comment here too is you don't want to completely remove settings.php since that will also remove it for other people pulling this code in which will cause their Drupal sites to break. You may want to checkout the HEAD version of settings.php
git checkout HEAD sites/default/settings.php
And then investigate either of these options http://gitready.com/intermediate/2009/02/18/temporarily-ignoring-files.html http://git-scm.com/docs/gitignore
Great work!
This looks good! I've added some supplemental issues to this as well https://github.com/kalamuna/playbox/issues/60
doing the below issue, and testing out github
In the pane that talks about kalamuna the logo should link to the kalamuna website easy
54