Closed patrickho81 closed 9 years ago
Good start on this one too. On thing that i noticed is i think you created this branch from your branch over here https://github.com/kalamuna/playbox/pull/57. What you will want to do is always checkout from master. That way pull requests don't rely on code from other pull requests. Something like this
# Working on PR1
git checkout master
git checkout -b pr-1-branch
#ADD SOME CODE
git add -A
git commit -m "All the codez"
git push origin pr-1-branch
# Moving to another issue
git checkout master
git checkout -b some-other-branch
#ADD SOME CODE
git add -A
git commit -m "Even more of the codez"
git push origin some-other-branch
ok, I think both pull requests should be okay now. I added back the default settings.php, and make this pull request only for this one issue.
Good work here @patrickho81 added this follow up issue https://github.com/kalamuna/playbox/issues/62 for anyone else to do!
The 'So, how does this work?' pane does not look good on tablet. #36
added class col-sm-6 to the div