Closed kalanakt closed 1 year ago
✅ Merging this PR will increase code quality in the affected files by 1.39%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 53.90 ⛔ | 49.10 ⛔ | -4.80 👍 |
Method Length | 302.79 ⛔ | 302.36 ⛔ | -0.43 👍 |
Working memory | 19.71 ⛔ | 19.28 ⛔ | -0.43 👍 |
Quality | 15.49% ⛔ | 16.88% ⛔ | 1.39% 👍 |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 995 | 965 | -30 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
bot.py | 67.66% 🙂 | 62.87% 🙂 | -4.79% 👎 |
Uploader/button.py | 6.22% ⛔ | 7.37% ⛔ | 1.15% 👍 |
Uploader/callbacks.py | 62.33% 🙂 | 62.60% 🙂 | 0.27% 👍 |
Uploader/commands.py | 89.32% ⭐ | 89.32% ⭐ | 0.00% |
Uploader/config.py | 66.30% 🙂 | 65.73% 🙂 | -0.57% 👎 |
Uploader/dl_button.py | 16.67% ⛔ | 18.12% ⛔ | 1.45% 👍 |
Uploader/echo.py | 5.12% ⛔ | 5.72% ⛔ | 0.60% 👍 |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
Uploader/echo.py | echo | 78 ⛔ | 1137 ⛔ | 22 ⛔ | 3.66% ⛔ | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
Uploader/button.py | youtube_dl_call_back | 54 ⛔ | 957 ⛔ | 23 ⛔ | 5.13% ⛔ | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
Uploader/dl_button.py | ddl_call_back | 44 ⛔ | 872 ⛔ | 20 ⛔ | 8.57% ⛔ | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
Uploader/dl_button.py | download_coroutine | 14 🙂 | 213 ⛔ | 16 ⛔ | 35.25% 😞 | Try splitting into smaller methods. Extract out complex expressions |
Uploader/callbacks.py | button | 7 ⭐ | 140 😞 | 10 😞 | 57.11% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
This pull request introduces 9 alerts and fixes 9 when merging d3b34d216fa3f45a0380906a0b564fbde2f06205 into 51048df4f69bd7a82dafcd6fada09c1b60d1bfa1 - view on LGTM.com
new alerts:
fixed alerts:
tring to fix error About [#27, #30, #32, #37]