search

kalaspuffar / secure-quick-reliable-login

This repository is an implementation for SQRL (Secure Quick Reliable Login) on Android.
MIT License
116 stars 29 forks source link

Migrate project to AndroidX #261

Open sengsational opened 5 years ago

sengsational commented 5 years ago

Address if and when the project should be migrated to using the AndroidX scheme for package management. Right now we have the following affected:

com.android.support:appcompat-v7
com.android.support:design
com.android.support.constraint:constraint-layout
com.android.support:support-v4  
com.android.support.test:runner
com.android.support.test:rules
com.android.support.test.espresso:espresso-core
com.android.support.test.espresso:espresso-contrib
com.android.support.test.espresso:espresso-intents
com.android.support.test.espresso:espresso-accessibility 
com.android.support.test.espresso:espresso-web
com.android.support.test.espresso.idling:idling-concurrent
com.android.support.test.espresso:espresso-idling-resource

https://developer.android.com/jetpack/androidx

kalaspuffar commented 5 years ago

I'm carefully optimistic about androidx. Just removed all Kotlin code added by junior developers at my company. Having a codebase with half code in one language and half in another made it unusable.

So using new libraries in an application that requires solid execution is not a good strategy. Then again give it a couple of years and we can upgrade when all the bugs are handled :)

Then again we have more work to do with stability if I look at the feedback from the forums.

sesam commented 5 years ago

It seems androidx is the only option looking 1-3 years forward, but that it does not bring any advantage right now or in the next months. So... NACK :)