search

kalaspuffar / secure-quick-reliable-login

This repository is an implementation for SQRL (Secure Quick Reliable Login) on Android.
MIT License
115 stars 29 forks source link

Change to use Constraint Layout v2 Flow instead of FlexBox #334

Open kalaspuffar opened 5 years ago

kalaspuffar commented 5 years ago

Today we have a dependency on an extra library to wrap elements on one page.

With the new constraint layout concept flow in constraint layout v2, you can accomplish this task without adding an extra dependency.

Thoughts @alexhauser

https://www.youtube.com/watch?v=29gLA90m6Gk

alexhauser commented 5 years ago

Thanks for the heads-up @kalaspuffar , I will look into it!

alexhauser commented 5 years ago

Hi @kalaspuffar,

if my findings are correct, Constraint Layout 2 would support everything we need, but is now only at version 2.0.0 beta 1.

Do you agree that we should wait for a stable release version before jumping on it? If would feel strange to swap out a mature dependency for another one that's only in beta. Because after all, ContraintLayout is also an external dependency.

Best regards, Alex

kalaspuffar commented 5 years ago

Hi @alexhauser

Exactly, we are on the same page. Constraint layout is a dependency we use heavily but switching to a beta version is not a good idea even if google betas are pretty stable but when they actually release we can do the switch. Maybe even wait for version 2.0.1 :)

Best regards Daniel