rbpatt2019
commented
4 years ago I love the project! You've got a test directory, but you don't have any test file or functions in there (not counting the poetry generated version assert). The notebook in the test directory, while useful for making sure code runs, is more scratchpad work that doesn't necessarily need to be uploaded to github. As a minor issue - if you've defined a function in a *.py file, you should import it into your notebook, rather than defining it in the notebook as well.
On the whole, awesome project! Good job tackling a relevant question and producing a usable tool!
This is very impressive. I like the ambition! Keep an I on the rubric though as you progress though. Even if your project is a flop and you don't achieve your goals you can troubleshoot it after the due date to get it doing what you want. In the meantime, it is important that you clearly check the boxes of documentation, modularity, and testing. They are easy points that will be available if you just tweak your code organization and just write in some comments in the appropriate format. Ask for help if you don't know what is required. A basic demo of getting the api working and some rudimentary data manipulation will get many of the other available points in the rubric. And then getting all the ids by the end of the course is something that we can help figure out!