kalbasit / arcanist-go

Phabricator's Arcanist Golang support.
Apache License 2.0
19 stars 10 forks source link

fix: Use 'go vet' instead of 'go tool vet' #7

Closed derekargueta closed 5 years ago

derekargueta commented 5 years ago

In Go 1.12, go tool vet is deprecated in favor of go vet, so this breaks when upgrading to Go 1.12. The output looks like:

- CommandException: Command failed with error #1!
      COMMAND
      'go' 'tool' 'vet' '/path/to/application.go'

      STDOUT
      (empty)

      STDERR
      vet: invoking "go tool vet" directly is unsupported; use "go vet"

Relevant Go 1.12 release note: https://golang.org/doc/go1.12#vet

kalbasit commented 5 years ago

Thank you!