search

kalbek / JS-Capstone-Project

3 stars 1 forks source link

JS Group capstone: Setting up kanban board #21

Open kalbek opened 1 year ago

kalbek commented 1 year ago
abdulhamiid commented 1 year ago

Status: Required Changes :recycle:

Hi Team, Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there! :running_man: :runner:

## Highlights 🌟 - ✔️ Descriptions are descriptive - ✔️ Setup Kanban board with a GitHub project ## Required Changes ♻️ _Please kindly check the comments under the review._ Your Cards 👇 ![image](https://user-images.githubusercontent.com/78251927/232589470-94d72def-2c24-4e69-87a4-3de3c73514f8.png) Kindly ensure that all cards are assigned to the team members. After assigning each card you should see a circle with the user's avatar on each card. See the example below: assigned_card According to the [project requirements](https://github.com/microverseinc/curriculum-javascript/blob/main/group-capstone/setup_kanban_board.md) - Since you are a group of 2, you decide who in your team is `Student A` and `Student B`. - Each of the team members should assign themselves to the correct cards. - You decide who will be the assignee for the cards marked as group tasks. All cards on your Kanban board should have assignees. 🛠🤝 ## Optional suggestions 🤷‍♂️ _Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better._ Cheers and Happy coding!👏👏👏 ## Important Notes 📝 - Feel free to leave any questions or comments in the PR thread if something is not 100% clear. - Please, remember to tag me in your question so I can receive the notification. **_Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise._** ------ _As described in the [Code reviews limits policy](https://microverse.zendesk.com/hc/en-us/articles/1500004088561) you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using [this form](https://airtable.com/shrQAqnBwek5a0O0s)._
Owusu-Desmond commented 1 year ago

Hi @kalbek and @Naledi-Dikgale ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Highlights

📌 You have assigned project tasks to team members✅ 📌 Great working on the setup of the project Kanban board ✅

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.