Feature/add recursive directory operations

kalbhor / MusicRepair

Fixes music metadata and adds album art.

MIT License

596 stars 43 forks source link

Feature/add recursive directory operations #14

Closed brandonb927 closed 7 years ago

brandonb927 commented 7 years ago

Addresses https://github.com/lakshaykalbhor/MusicRepair/issues/10

Cleaned up some formatting (my OCD kicks in when I code 💃)
Introduced new -R, --recursive option for fixing and reverting
Added more noticeable error messaging when something fails (red text will indicate an error)

unquietwiki commented 7 years ago

TIL about https://pypi.python.org/pypi/colorama : reminds me of the BBS days.

I'm still a bit of a Python noob myself, and was going to take a stab at this, if someone else didn't. I see you did your os.walk as for dirpath, , in walk('.'): ; is that dropping the other two tuples that walk generates?

brandonb927 commented 7 years ago

Ah this is a bit of my exposure to Go (lang) being introduced here. From what I've seen in other languages I coded in, if you want to simply ignore or not reference returned values you can denote them with _.

I'm not sure how widespread of a practice it is outside Go and other languages, but it's something I picked up and feel, if used appropriately, can be useful.

unquietwiki commented 7 years ago

@brandonb927 That's pretty clever, and good to know. Thank you. :)