search

kalbhor / MusicRepair

Fixes music metadata and adds album art.
MIT License
596 stars 43 forks source link

Recursive Fixing Logic is incorrect #21

Closed rhnvrm closed 7 years ago

rhnvrm commented 7 years ago

Suppose you have a tree like:

screenshot from 2016-12-19 22-45-07

Music repair will only fix I Hate U, I Love U by Gnash.

kalbhor commented 7 years ago 
            for dirpath, _, _ in walk('.'):
                chdir(dirpath)
                revert_music()

chdir is a wrong method, since after getting into first nested directory, musicrepair can't go into the second nested directory. Thanks for pointing this out. I'll rather pass in the path's of the folders as arguments to rever_music() than change directories altogether.

rhnvrm commented 7 years ago

@lakshaykalbhor: I'm working on a fix, and will send a PR in a few minutes.