search

kalcifer / ember-dragula

Simple drag and drop with dragula and ember
MIT License
27 stars 17 forks source link

Load dragula from NPM and upgrade ember-cli #30

Closed oskarrough closed 7 years ago

oskarrough commented 7 years ago

Hi, this moves the Dragula dependency to NPM and upgrades ember-cli (again) to get rid of bower completely.

kkincade commented 7 years ago

@oskarrough I think you've missed some references to bower, mainly the blueprints/ember-dragula/index.js file. I think that whole blueprints directory could be removed. With your fork, running ember install ember-dragula causes bower to be installed in the host application.

You could also remove references to bower within files such as .gitignore, .npmignore, etc.

oskarrough commented 7 years ago

@kkincade thank you. I removed the blueprints in master. Happy to accept a PR if there's more :)